From: Jeff Garzik <jgarzik@pobox.com>
To: Martin Hicks <mort@wildopensource.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
Greg KH <greg@kroah.com>,
linux-scsi@vger.kernel.org, Jesse Barnes <jbarnes@sgi.com>,
jeremy@sgi.com
Subject: Re: [PATCH] SATA Transport Attributes
Date: Mon, 29 Mar 2004 20:23:38 -0500 [thread overview]
Message-ID: <4068CC1A.3000803@pobox.com> (raw)
In-Reply-To: <20040330004601.GE18948@localhost>
Martin Hicks wrote:
> Hello,
>
> Here is a patch that introduces a Transport Attribute class for SATA
> devices. The patch also includes an update to the Vitesse driver to use
> the transport attribute.
>
> The only problem that I'm having right now is that sometimes I get
> a NULL pointer dereference in scsi_remove_device() when I rmmod sata_vsc.
> Although sdev->host->transportt->cleanup is NULL coming into the
> function, the call to class_device_unregister(&sdev->transport_classdev)
> somtimes makes ->cleanup non-NULL and bad things happen from there.
>
> I could not reproduce this when calling rmmod on the qla2200 driver.
>
> Any comments on this patch? Any ideas about this rmmod issue?
>
> The patch is against 2.6.5-rc1.
hmmm... since libata is moving out of drivers/scsi in 2.7, I would
rather leave it as-is. The port number is easily found from userspace,
assuming you know the PCI device, with zero code. This adds ~300 lines
of code to do that which is already doable... :)
Jeff
prev parent reply other threads:[~2004-03-30 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-30 0:46 [PATCH] SATA Transport Attributes Martin Hicks
2004-03-30 1:16 ` Greg KH
2004-03-30 1:23 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4068CC1A.3000803@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@steeleye.com \
--cc=greg@kroah.com \
--cc=jbarnes@sgi.com \
--cc=jeremy@sgi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mort@wildopensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox