From: Mike Christie <mikenc@us.ibm.com>
To: Jens Axboe <axboe@suse.de>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
Masao Fukuchi <fukuchi.masao@jp.fujitsu.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] improvement of fastfail operation
Date: Wed, 31 Mar 2004 15:15:59 -0800 [thread overview]
Message-ID: <406B512F.9090004@us.ibm.com> (raw)
In-Reply-To: <20040331221241.GR24370@suse.de>
Jens Axboe wrote:
> On Wed, Mar 31 2004, James Bottomley wrote:
>
>>On Wed, 2004-03-31 at 17:04, Jens Axboe wrote:
>>
>>>So the new patch you sent with this mail is no good. Your previous one
>>>should be adopted ;-)
>>
>>And the:
>>
>>
>> if (blk_pc_request(req))
>> leftover = req->data_len - bytes;
>>
>>Since end_that_request chunk won't muck with that, is that OK?
>
>
> It's a bit messy right now really, but it's up to the drivers to modify
> that one. So for partial completions, it should be updated to be
>
> leftover = req->data_len;
>
> as well.
>
Is that a typo? If drivers are to account for it, scsi should do
leftover = req->data_len - bytes;
?
next prev parent reply other threads:[~2004-03-31 23:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 0:38 [PATCH] improvement of fastfail operation Masao Fukuchi
2004-03-27 15:57 ` James Bottomley
2004-03-29 10:20 ` Mike Christie
2004-03-29 12:17 ` Masao Fukuchi
2004-03-31 1:29 ` James Bottomley
2004-03-31 5:14 ` Mike Christie
2004-03-31 22:04 ` Jens Axboe
2004-03-31 22:11 ` James Bottomley
2004-03-31 22:12 ` Jens Axboe
2004-03-31 23:15 ` Mike Christie [this message]
2004-04-01 6:47 ` Jens Axboe
[not found] ` <406BC50E.6090100@us.ibm.com>
2004-04-01 7:53 ` Mike Christie
2004-04-01 15:06 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=406B512F.9090004@us.ibm.com \
--to=mikenc@us.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=fukuchi.masao@jp.fujitsu.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox