From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Vasquez <praka@users.sourceforge.net>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] ibmvscsi driver - sixth version
Date: Thu, 01 Apr 2004 02:13:42 -0500 [thread overview]
Message-ID: <406BC126.1030700@pobox.com> (raw)
In-Reply-To: <20040401060300.GA13819@praka.local.home>
Andrew Vasquez wrote:
> On Wed, 31 Mar 2004, Jeff Garzik wrote:
>
>
>>>>12) in ibmvscsi_probe(), you want to use TASK_UNINTERRUPTIBLE here:
>>>>
>>>>+ set_current_state(TASK_INTERRUPTIBLE);
>>>>+ schedule_timeout(5);
>>>>
>>>>13) in the code pasted in #12, you should pass a value calculated
>>>>using the 'HZ' constant.
>>>
>>>Hmmm...above code copied from the qlogic driver...and it looked reasonable
>>>to me, but I'll tweak it.
>>
>>Well, qlogic is wrong too. Do you want to submit a patch fixing qlogic
>>while you're at it? ;-)
>>
>
>
> Fair enough - the driver isn't checking the return value of
> schedule_timeout() in many cases. How about the attached patch
> against scsi-misc-2.6.
Looks good to me...
but a question: in the cases you left TASK_INTERRUPTIBLE, do you care
at all about signals interrupting the wait? What are the implications
of signal delivery and a shorter schedule_timeout() on these remaining
cases?
Jeff
prev parent reply other threads:[~2004-04-01 7:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 5:34 [PATCH] ibmvscsi driver - third version Dave Boutcher
2004-02-25 13:45 ` Christoph Hellwig
2004-02-25 17:53 ` [PATCH] ibmvscsi driver - fourth version Dave Boutcher
2004-03-11 17:43 ` James Bottomley
2004-03-11 21:25 ` Dave Boutcher
2004-03-11 22:07 ` James Bottomley
2004-03-12 15:59 ` [PATCH] ibmvscsi driver - fifth version Dave Boutcher
2004-03-31 21:26 ` [PATCH] ibmvscsi driver - sixth version Dave Boutcher
2004-03-31 21:58 ` James Bottomley
2004-03-31 22:37 ` Dave Boutcher
2004-03-31 22:02 ` Jeff Garzik
2004-03-31 23:12 ` Dave Boutcher
2004-03-31 23:39 ` James Bottomley
2004-03-31 23:51 ` Dave Boutcher
2004-04-01 0:10 ` Jeff Garzik
2004-04-01 6:17 ` [PATCH] qla2xxx: sleep while IRQ disabled fix in eh_abort Andrew Vasquez
2004-04-01 15:04 ` James Bottomley
2004-04-01 0:16 ` [PATCH] ibmvscsi driver - sixth version Jeff Garzik
2004-04-01 6:03 ` Andrew Vasquez
2004-04-01 7:13 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=406BC126.1030700@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=praka@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox