From: Bart Van Assche <bvanassche@acm.org>
To: Seunghui Lee <sh043.lee@samsung.com>,
'Bean Huo' <huobean@gmail.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
sdriver.sec@samsung.com
Subject: Re: [PATCH] ufs: core: Use link recovery when the h8 exit failure during runtime resume
Date: Wed, 16 Jul 2025 08:14:20 -0700 [thread overview]
Message-ID: <4080315d-4d90-433d-85e3-db5eef48bc90@acm.org> (raw)
In-Reply-To: <005801dbf61f$7287e7d0$5797b770$@samsung.com>
On 7/16/25 12:01 AM, Seunghui Lee wrote:
> This issue arises from the race condition between the runtime pm
> worker and the error handler worker.
How could there be a race condition between the runtime PM code and UFS
error handling? Runtime PM is disabled while UFS error handling is in
progress by surrounding error handling with ufshcd_rpm_get_sync(hba) and
ufshcd_rpm_put(hba).
> I believe it would be safer to handle recovery within the runtime pm
> worker itself.
I do not agree. If runtime PM and the UFS error handler really happen in
parallel, the proper way to fix this is by serializing both activities
instead of introducing concurrent error handling.
Thanks,
Bart.
next prev parent reply other threads:[~2025-07-16 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250714090630epcas1p28ab8afec11bbab4d256dfe6649d3b00b@epcas1p2.samsung.com>
2025-07-14 9:06 ` [PATCH] ufs: core: Use link recovery when the h8 exit failure during runtime resume Seunghui Lee
2025-07-14 11:21 ` Bean Huo
2025-07-15 2:23 ` 이승희
2025-07-15 12:47 ` Bean Huo
2025-07-15 15:21 ` Bean Huo
2025-07-16 7:01 ` Seunghui Lee
2025-07-16 7:49 ` Seunghui Lee
2025-07-16 13:35 ` Bean Huo
2025-07-16 15:02 ` Bart Van Assche
2025-07-17 6:12 ` Seunghui Lee
2025-07-16 15:14 ` Bart Van Assche [this message]
2025-07-17 6:01 ` Seunghui Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4080315d-4d90-433d-85e3-db5eef48bc90@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=huobean@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sdriver.sec@samsung.com \
--cc=sh043.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).