From: Jeff Garzik <jgarzik@pobox.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: [PATCH] buggy comment in scsi_decide_disposition
Date: Fri, 14 May 2004 01:44:45 -0400 [thread overview]
Message-ID: <40A45CCD.5040902@pobox.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
AFAICS this comment is incorrect. The switch target in question,
DID_SOFT_ERROR, jumps to the maybe_retry label, which increments a retry
counter.
This retry counter appears to avoid the endless loops that the comment
refers to.
Although this patch only deletes a comment, please do review it with a
careful eye.
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 662 bytes --]
===== drivers/scsi/scsi_error.c 1.74 vs edited =====
--- 1.74/drivers/scsi/scsi_error.c Mon Apr 19 04:12:13 2004
+++ edited/drivers/scsi/scsi_error.c Fri May 14 01:41:37 2004
@@ -1289,15 +1289,6 @@
* that it indicates SUCCESS.
*/
return SUCCESS;
- /*
- * when the low level driver returns did_soft_error,
- * it is responsible for keeping an internal retry counter
- * in order to avoid endless loops (db)
- *
- * actually this is a bug in this function here. we should
- * be mindful of the maximum number of retries specified
- * and not get stuck in a loop.
- */
case DID_SOFT_ERROR:
goto maybe_retry;
case DID_IMM_RETRY:
reply other threads:[~2004-05-14 5:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A45CCD.5040902@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox