[PATCH] buggy comment in scsi_decide_disposition

[PATCH] buggy comment in scsi_decide_disposition

[Jeff Garzik]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]


AFAICS this comment is incorrect.  The switch target in question, 
DID_SOFT_ERROR, jumps to the maybe_retry label, which increments a retry 
counter.

This retry counter appears to avoid the endless loops that the comment 
refers to.

Although this patch only deletes a comment, please do review it with a 
careful eye.



[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 662 bytes --]

===== drivers/scsi/scsi_error.c 1.74 vs edited =====
--- 1.74/drivers/scsi/scsi_error.c	Mon Apr 19 04:12:13 2004
+++ edited/drivers/scsi/scsi_error.c	Fri May 14 01:41:37 2004
@@ -1289,15 +1289,6 @@
 		 * that it indicates SUCCESS.
 		 */
 		return SUCCESS;
-		/*
-		 * when the low level driver returns did_soft_error,
-		 * it is responsible for keeping an internal retry counter 
-		 * in order to avoid endless loops (db)
-		 *
-		 * actually this is a bug in this function here.  we should
-		 * be mindful of the maximum number of retries specified
-		 * and not get stuck in a loop.
-		 */
 	case DID_SOFT_ERROR:
 		goto maybe_retry;
 	case DID_IMM_RETRY: