RE: [PATCH]: Flexible timeout infrastructure

Smart, James
2004-06-16T17:11:36Z

I can appreciate the protectionist point of view. My only contention is -
how do you really derive that 1 reset is any less valid than 2 ? it totally
depends on what the original timeout was relative to whatever the duration
is for the LLDD event that is requesting the reset.

-- James

> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@SteelEye.com]
> Sent: Wednesday, June 16, 2004 1:04 PM
> To: Smart, James
> Cc: Luben Tuikov; Mike Anderson; SCSI Mailing List
> Subject: RE: [PATCH]: Flexible timeout infrastructure
>
>
> On Wed, 2004-06-16 at 11:58, Smart, James wrote:
> > So why increment the retries counter at all ?
>
> So drivers can't return EH_RESET_TIMER forever. This really ties the
> handling into the behaviour the user has requested. The only wrinkle
> was the no retry streaming commands. The assumption is that a retry
> doesn't actually happen under eh_timed_out, but only an attempt to
> collect an existing command which may be delayed because of
> transport or
> other problems the host knows about.
>
> James
>
>