Re: [PATCH]: Flexible timeout infrastructure

Christoph Hellwig
2004-06-15T15:49:15Z

On Tue, Jun 15, 2004 at 11:46:08AM -0400, Luben Tuikov wrote:
> >That's why the plan is to move it into the transport class slowly. Remeber
> >there are much more SPI drivers than just aic7xxx/aic79xx ;-)
>
> Yes, in which case it would look like FreeBSD. Then SCSI Core will
> have to implement _all_ transports it wants to support (a la USB Storage).

Umm, no. Look at a recent Linux 2.6 codebase. We support modular transport
classes so it's _NOT_ a big mess like FreeBSD. And we won't stop providing
sensible defaults abyway.

> But if we *do* allow for this patch, then _moving_ this functionality
> into the transport class recovery would be really easy. Just move
> eh_cmd_timed_out() into the transport class.

Show us a patch with your SPI EH improvements.