Re: [PATCH]: Flexible timeout infrastructure

Luben Tuikov
2004-06-16T18:58:16Z

> > So why increment the retries counter at all ?
>
> So drivers can't return EH_RESET_TIMER forever. This really ties the

EH_RESET_TIMER means "This command had nothing to do with why
its timer timed out and is expected to complete shortly."

Do we want to increment its retry counter for this,
as it isn't really a retry.

> handling into the behaviour the user has requested. The only wrinkle
> was the no retry streaming commands. The assumption is that a retry

They also fall in the same category -- the application client cannot
retry them, but the LLDD knows best and it may perform some magic
for which SCSI Core shouldn't account for.

> doesn't actually happen under eh_timed_out, but only an attempt to
> collect an existing command which may be delayed because of transport or
> other problems the host knows about.

Can we get a finalised patch so we can test it?
James, is the one you posted what you'll have in?

--
Luben