From: Douglas Gilbert <dougg@torque.net>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: SCSI sg: Questions regarding jiffies usage
Date: Mon, 12 Jul 2004 15:35:06 -0400 [thread overview]
Message-ID: <40F2E7EA.6010907@torque.net> (raw)
In-Reply-To: <20040711004153.GZ28324@fs.tum.de>
Adrian Bunk wrote:
> Hi,
>
> I have some questions regarding jiffies usage in the SCSI sg driver in
> 2.6.7-mm7:
>
>
> Is there a good reason for the local sg_ms_to_jif/sg_jif_to_ms functions
> instead of using the time.h msecs_to_jiffies/jiffies_to_msecs macros?
Adrian,
I don't think the msec_to_jiffies() macro was there when I
wanted it. So the sg driver should be changed to use the
macros in time.h .
> In function sg_new_write:
> timeout = sg_ms_to_jif(srp->header.timeout);
> How is it possible that srp->header.timeout isn't already
> in jiffies?
The sg_new_write() function is invoked when the sg_io_hdr
interface structure is used (compared with the older
sg_header structure). The unit of the timeout in the
sg_io_hdr structure is milliseconds [which is probably
overkill]. The mid level wants timeouts in jiffies.
> Why do both sg_add_request and sg_common_write set
> duration = jiffies
It doesn't look like both are required.
Doug Gilbert
next prev parent reply other threads:[~2004-07-12 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-11 0:41 SCSI sg: Questions regarding jiffies usage Adrian Bunk
2004-07-12 19:35 ` Douglas Gilbert [this message]
2004-07-12 22:46 ` Adrian Bunk
2004-07-12 23:11 ` Douglas Gilbert
2004-07-12 23:59 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40F2E7EA.6010907@torque.net \
--to=dougg@torque.net \
--cc=bunk@fs.tum.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox