RE: PATCH [3/5] qla2xxx: TCQ fixes

Andrew Vasquez
2004-07-13T17:27:08Z

On Monday, July 12, 2004 2:41 PM, James Bottomley wrote:
>
> For the way the qla2xxx works, the correct tag usage would be to use
> per HBA tags (which were introduced for aic7xxx but never used by
> them, so I haven't actually created the mid-layer API), to populate
> your queue handle field with the tag and to dispense with your
> outstanding_cmnds[] array
>

Ok, I'll bite. What did you have in mind? I've taken a quick peek
through the scsi code, the per-hba tag stuff must still be in your
head...

> and use scsi_find_tag() to get back the command from the handle.
>

Just a small comment, isn't the scsi_populate_tag_msg() function
quietly truncating the request->tag value?

Regards,
Andrew Vasquez