Re: PATCH [3/5] qla2xxx: TCQ fixes

James Bottomley
2004-07-12T21:41:41Z

On Mon, 2004-07-12 at 09:05, Andrew Vasquez wrote:
> ChangeSet
> 1.1867 04/07/12 09:38:28 andrew.vasquez@apc.qlogic.com +2 -0
> Correct usage of tag-command-queueing methods:

I really don't think it is.

For the way the qla2xxx works, the correct tag usage would be to use per
HBA tags (which were introduced for aic7xxx but never used by them, so I
haven't actually created the mid-layer API), to populate your queue
handle field with the tag and to dispense with your outstanding_cmnds[]
array and use scsi_find_tag() to get back the command from the handle.

Since you'd be the first user of this API, I'd be happy to come up with
it for a willing victim^Wvolunteer.

James