RE: PATCH [3/5] qla2xxx: TCQ fixes

James Bottomley
2004-07-13T17:43:45Z

On Tue, 2004-07-13 at 12:24, Andrew Vasquez wrote:
> Ok, I'll bite. What did you have in mind? I've taken a quick peek
> through the scsi code, the per-hba tag stuff must still be in your
> head...

Well, it exsits in the block layer (the ability to specify an existing
tag map to blk_queue_init_tags(). Jens is going to expose a bit more of
the tag map machinary to make that useful, then for host global tags,
we'll generate a single tag map and share it amongst all the queues.

> Just a small comment, isn't the scsi_populate_tag_msg() function
> quietly truncating the request->tag value?

Not for SPI, no. However, we probably need a different API for the
sixteen bit tag values FC can use?

James