From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Bryant Subject: Re: device_suspend() levels [was Re: [patch] ACPI work on aic7xxx] Date: Tue, 20 Jul 2004 14:34:42 -0400 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <40FD65C2.7060408@optonline.net> References: <40FD38A0.3000603@optonline.net> <20040720155928.GC10921@atrey.karlin.mff.cuni.cz> <40FD4CFA.6070603@optonline.net> <20040720174611.GI10921@atrey.karlin.mff.cuni.cz> <40FD6002.4070206@optonline.net> <1090347939.1993.7.camel@gaston> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from thunderdog.allegientsystems.com ([208.251.178.238]:38294 "EHLO lasn-001.allegientsystems.com") by vger.kernel.org with ESMTP id S266115AbUGTSe0 (ORCPT ); Tue, 20 Jul 2004 14:34:26 -0400 In-Reply-To: <1090347939.1993.7.camel@gaston> List-Id: linux-scsi@vger.kernel.org To: Benjamin Herrenschmidt Cc: Pavel Machek , linux-scsi@vger.kernel.org, random1@o-o.yi.org, Luben Tuikov , Linux Kernel list Benjamin Herrenschmidt wrote: > 2 comments here: > > - The low level bus state (PCI D state for example) and the "linux" > state should be 2 different entities. > > - For PCI, we probably want a hook so the arch can implement it's own > version of pci_set_power_state() so that ACPI can use it's own trickery > there. Ok, so the takeaway message for driver writers is to treat the pci_dev->suspend() state parameter as an opaque value as far as possible, and just pass it on to the other layers