Re: [patch] ACPI work on aic7xxx

Nathan Bryant
2004-07-20T16:48:46Z

Pavel Machek wrote:

>>+#if 0
>>+ switch(state)
>>+ {
>>+ case 1: /* S1 */
>>+ device_state=1; /* D1 */;
>>+ break;
>>+ case 3: /* S3 */
>>+ case 4: /* S4 */
>>+ device_state=3; /* D3 */;
>>+ break;
>>+ default:
>>+ return -EAGAIN /*FIXME*/;
>>+ break;
>>+ }
>>+#else
>>+ device_state = state;
>>+#endif
>
>
> Can you kill #if 0 code?

Yes. This is a work in progress. Interestingly, the ifdef'd-out code was
pasted from mptbase.c in the MPT Fusion driver. If it's broken here,
it's probably broken there -- seems the state parameter passed to the
pci resume callback is intended to be a PCI D state, not an ACPI S
state. Can somebody confirm or deny? The kernel is actually passing
state 2 (D2) to the driver when I enter ACPI S3, so presumably the same
failure could happen to fusion.