Re: device_suspend() levels [was Re: [patch] ACPI work on aic7xxx]

Pavel Machek
2004-07-20T19:23:41Z

Hi!

> > > 2 comments here:
> > >
> > > - The low level bus state (PCI D state for example) and the "linux"
> > > state should be 2 different entities.
> > >
> > > - For PCI, we probably want a hook so the arch can implement it's own
> > > version of pci_set_power_state() so that ACPI can use it's own trickery
> > > there.
> >
> > Ok, so the takeaway message for driver writers is to treat the
> > pci_dev->suspend() state parameter as an opaque value as far as
> > possible, and just pass it on to the other layers
>
> NO ! The exact opposite in fact. I'll work on cleaning that up and
> write some doco this week with Pavel.

Agreed. I do not have strong opinion about Sx or Dx, but it should
be enum or equivalent so it is hard to get wrong. [And not "really
easy to get wrong because noone knows for sure", as it is now].

Pavel
--
Horseback riding is like software...
...vgf orggre jura vgf serr.