From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E9AE15DBBB for ; Wed, 28 Feb 2024 16:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709136682; cv=none; b=ro8Tu6Nlob1q8GJrBvMKvJ2hJNLKdPM3XdSqVLERX6MgupRMxlL+vpm/T+TVVOxYPiaUSlYAHqg4mNDeZ3Yw7wfXxGZ0sI9smblwXWIQIIu2oqqcu0d2m4Ow3M74C/m+MKcKr7963Y5DFZlK9jjnBaEE5nxLx+sDiWNkx6BxVCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709136682; c=relaxed/simple; bh=0/SXo7LUmEd3Ek4bAWDkgWgcqOozxVlfBaRmQBjkoGY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AYJIEwbaTFh/jufwVcKiqG2XBpFH6gutFse/IdCEVhP3GZmKBUabXFrLgARmgCJ+8jE/lJB2zBuGGCtJaieKCtMI+1xuPYLLFEue4tGTBRuRvVPRT8JfPCvXBSX5Py897LZiHmn4//VHKL4cK43IyFARaIDUsH7jiRDQ7zMPaXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=BqQufdcG; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="BqQufdcG" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-512bde3d197so5296202e87.0 for ; Wed, 28 Feb 2024 08:11:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1709136678; x=1709741478; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jgP8egN9jzbqWUtue2PPYahrXFZRT/aZTCnQiSVag14=; b=BqQufdcG93NRMdtlmwIbirbO3IJPfo3SQexOsal13voIGqPi6mHJmRC3klyrLejE8Z BhTE9MKKi86w5Z9GyTkTCDVw2JdiotqLVpYXNLfdcGU8jFjbYn6FYhcYCCxpepKYn4+/ ydHNCxEoj09Otd0IcAnbbtf856vJ6J7AN+UZdifABfOm5MCpSkXNwKqVCvKnK6rfQNPc 0OYk/ntEe+G7AfWtxwf/JrwE70bM1Bw/H9JeBtZYmb5mtlQK8ZwHgqpzgr2d7I7+WKyr xk3/nwlidEGLWLGLxWO5i+Q+xE423NHcDiwhytDs0VctGULjDQWOAIqsyUMqWrd16Cqj Jbig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709136678; x=1709741478; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jgP8egN9jzbqWUtue2PPYahrXFZRT/aZTCnQiSVag14=; b=cX9GqqZCP8lcddG50A1qwL2Cp0FpQZahnfIG0qVCxrQUvuCyV8x1oLCKr+bU0LhW9G fvPAQfOvNnt9O83bpsNUEekfPds9V2nG+DffZpBEt5qY0MqWbBi7K5bztqpGoFfvFVH0 mawBHzAM73672jUUdPI6qXzHxIm2GeqKcQuZDGq4J3XkHdgFQD6ZRiFnwr8b2I8tcT1c VXpu10y9bt9r4JRgWGf5ZojS/CKF5pvPp7nSkv7MFfkmvIJE9sFOQf3in7IjDd1SX/DY bHWywd1+PvuuVtXPVusfyrxKOxNat38agaqtT4OetOLUIlHm8ljzpPubMO71DwTywJe2 bZPw== X-Forwarded-Encrypted: i=1; AJvYcCXT6pbOGsq+BPqrr++FiVbhUwPKv04ab5A6mN0D1x5haaZwkUNrMh6/B9gXfqOpJRigGvK0/QkeASKfgMlvViB5efnJDQ9//0Fl/w== X-Gm-Message-State: AOJu0YxzOwzEp6tDVPHcesjLxTVG0OEtxpzoFvWhwimCXJk82xyalfR0 s9AJc8Mq1+K7oxsAnNQUJlJz0MF4LIHEEBMXphMkbLKHDjLMtIyZdiEhko5QblI= X-Google-Smtp-Source: AGHT+IG9pHQRYhPAl7gRn1uIw/tLwD3MS/O8eajbw9qNVQ3ZgXy9u/fSDDd8ADWubwAiIqrGVivLDQ== X-Received: by 2002:a19:2d11:0:b0:513:174e:a152 with SMTP id k17-20020a192d11000000b00513174ea152mr104784lfj.29.1709136678541; Wed, 28 Feb 2024 08:11:18 -0800 (PST) Received: from ?IPV6:2001:a61:1366:6801:d8:8490:cf1a:3274? ([2001:a61:1366:6801:d8:8490:cf1a:3274]) by smtp.gmail.com with ESMTPSA id w4-20020a5d4044000000b0033b7ce8b496sm14762361wrp.108.2024.02.28.08.11.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Feb 2024 08:11:18 -0800 (PST) Message-ID: <4111f9ba-e1dc-4158-af6f-c048bcf8ccd2@suse.com> Date: Wed, 28 Feb 2024 17:11:16 +0100 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: RIP on discard, JMicron USB adaptor Content-Language: en-US To: Alan Stern , Keith Busch Cc: Harald Dunkel , Jens Axboe , Bart Van Assche , "Martin K. Petersen" , linux-block@vger.kernel.org, linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org References: <70bc51d7-c8a2-4b06-ab7a-e321d20db49a@aixigo.com> <62296d89-f7e6-4f54-add8-35b531dc657c@rowland.harvard.edu> <76fcb1b1-cdf2-45d0-aeab-c712ee517b34@rowland.harvard.edu> From: Oliver Neukum In-Reply-To: <76fcb1b1-cdf2-45d0-aeab-c712ee517b34@rowland.harvard.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28.02.24 17:01, Alan Stern wrote: >> In the code comments above the WARN, this condition indicates "the >> discard granularity isn't set by buggy device driver". The block layer >> needs this set if your driver also sets the max_discard_sectors limit. > > The usb-storage and uas drivers do not set any of these; however, the > SCSI sd driver does. Maybe that's where the problem lies. Adding more > CC's. Hi, that seems to be conditional on READ_CAPACITY_16 being used. From the cropped dmesg we cannot tell. We need more. Regards Oliver