can_queue modification within select_queue_depths

can_queue modification within select_queue_depths

[Saeed Bishara]

Hi,
    is it allowed to modify the host can_queue with select_queue_depths 
function?
    if yes, is it needed to lock/unlock io_request_lock ?
thanks  

-- 
Saeed Bishara
Marvell Semiconductor Israel Ltd
6 Ha'mada St.
Industrial Area
P.O. Box 692
Yokneam 20692 ISRAEL
Email    -  Saeed.Bishara@il.marvell.com
Tel      -  + 972 4 9091602
Cell     -  + 972 54 7619030
Fax      -  + 972 4 9091505
WWW Page:     http://www.marvell.com 

This message may contain confidential, proprietary or legally privileged information. The information is intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by telephone, or by e-mail and delete the message from your computer.

Re: can_queue modification within select_queue_depths

[Christoph Hellwig]

On Wed, Aug 18, 2004 at 02:17:05PM +0300, Saeed Bishara wrote:
> Hi,
>     is it allowed to modify the host can_queue with select_queue_depths 
> function?

Yes.

>     if yes, is it needed to lock/unlock io_request_lock ?
> thanks  

Dunno about 2.4 locking, but given this is at init time and thus implicitly
serialized I wouldn't care too much about locking.


BTW, if you happen to work on a driver for the marvell SATA part please
talk to Jeff Garzik who is doing a libata driver for it.  Also note that
we're not going to accept pure SCSI LLDDs for (S)ATA hardware.

Re: can_queue modification within select_queue_depths

[Saeed Bishara]

yes I'm working on Marvells sata devices, I'm still waiting for Jeff for 
an initial libata version.


Christoph Hellwig wrote:

>On Wed, Aug 18, 2004 at 02:17:05PM +0300, Saeed Bishara wrote:
>  
>
>>Hi,
>>    is it allowed to modify the host can_queue with select_queue_depths 
>>function?
>>    
>>
>
>Yes.
>
>  
>
>>    if yes, is it needed to lock/unlock io_request_lock ?
>>thanks  
>>    
>>
>
>Dunno about 2.4 locking, but given this is at init time and thus implicitly
>serialized I wouldn't care too much about locking.
>
>
>BTW, if you happen to work on a driver for the marvell SATA part please
>talk to Jeff Garzik who is doing a libata driver for it.  Also note that
>we're not going to accept pure SCSI LLDDs for (S)ATA hardware.
>
>  
>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>  
>