Re: [PATCH] add extra inquiry byte 56 data to struct scsi_device

[Douglas Gilbert <dougg@torque.net>]

James Bottomley wrote:
> The idea here is to get a full range of device capabilites in the
> scsi_device structure so there's absolutely no need at all for drivers
> to snoop the inquiry data.
> 
> The missing parameters were:
> 
> dt_only - means the device only supports DT transfers (not ST)
> ius - means the device supports information unit (IU) transfers
> qas - means the device supports the Quick Arbitration and Selection
> protocol
> 
> Our rather misnamed ones are:
> 
> ppr - means the device does DT (DT negotiation may only be done via PPR)
> wdtr - means the device does wide
> sdtr - means the device does sync

James,
What you are proposing is only relevant for the SPI
transport. Maybe the accessors should be placed in
scsi_tranport_spi.c and struct scsi_device get a
a transport dependent "hang on". Then some of that older
SPI stuff could get migrated out of struct scsi_device
so it stops growing.

Doug Gilbert