scsi eh (in linux 2.4) retries a command without limit

scsi eh (in linux 2.4) retries a command without limit

[Saeed Bishara]

Hi,
    I've seen a case where timeout occurs, and one of the timedout 
commands it a read to a sector with ecc corrupted.
    when the error handler enters to action, it retries that read which 
alwasy fails on medium error, but unfortunalty the error handler     
retries it again and again without finish.
    I looked  into the scsi error handler code (kernel 2.4.26), and I 
found that the function scsi_send_eh_cmnd retries the command ( if 
scsi_eh_completed_normally return NEEDS_RETRY) without any restriction 
and without increasing and checking the retries counter.

saeed

-- 
Saeed Bishara
Marvell Semiconductor Israel Ltd
6 Ha'mada St.
Industrial Area
P.O. Box 692
Yokneam 20692 ISRAEL
Email    -  Saeed.Bishara@il.marvell.com
Tel      -  + 972 4 9091602
Cell     -  + 972 54 7619030
Fax      -  + 972 4 9091505
WWW Page:     http://www.marvell.com 

This message may contain confidential, proprietary or legally privileged information. The information is intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by telephone, or by e-mail and delete the message from your computer.