[PATCH] update scsi_eh_get_sense commentary

[PATCH] update scsi_eh_get_sense commentary

[Christoph Hellwig]

--- 1.79/drivers/scsi/scsi_error.c	2004-06-19 16:47:16 +02:00
+++ edited/drivers/scsi/scsi_error.c	2004-08-24 13:38:13 +02:00
@@ -643,15 +643,13 @@
  * Notes:
  *    This has the unfortunate side effect that if a shost adapter does
  *    not automatically request sense information, that we end up shutting
- *    it down before we request it.  All shosts should be doing this
- *    anyways, so for now all I have to say is tough noogies if you end up
- *    in here.  On second thought, this is probably a good idea.  We
- *    *really* want to give authors an incentive to automatically request
- *    this.
+ *    it down before we request it.
  *
- *    In 2.5 this capability will be going away.
+ *    All drivers should request sense information internally these days,
+ *    so for now all I have to say is tough noogies if you end up in here.
  *
- *    Really?  --hch
+ *    XXX: Long term this code should go away, but that needs an audit of
+ *         all LLDDs first.
  **/
 static int scsi_eh_get_sense(struct list_head *work_q,
 			     struct list_head *done_q)

Re: [PATCH] update scsi_eh_get_sense commentary

[Luben Tuikov]

Very good!

Christoph Hellwig wrote:
> 
> --- 1.79/drivers/scsi/scsi_error.c      2004-06-19 16:47:16 +02:00
> +++ edited/drivers/scsi/scsi_error.c    2004-08-24 13:38:13 +02:00
> @@ -643,15 +643,13 @@
>   * Notes:
>   *    This has the unfortunate side effect that if a shost adapter does
>   *    not automatically request sense information, that we end up shutting
> - *    it down before we request it.  All shosts should be doing this
> - *    anyways, so for now all I have to say is tough noogies if you end up
> - *    in here.  On second thought, this is probably a good idea.  We
> - *    *really* want to give authors an incentive to automatically request
> - *    this.
> + *    it down before we request it.
>   *
> - *    In 2.5 this capability will be going away.
> + *    All drivers should request sense information internally these days,
> + *    so for now all I have to say is tough noogies if you end up in here.
>   *
> - *    Really?  --hch
> + *    XXX: Long term this code should go away, but that needs an audit of
> + *         all LLDDs first.
>   **/
>  static int scsi_eh_get_sense(struct list_head *work_q,
>                              struct list_head *done_q)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>