Re: PATCH: (as355) Fix test for valid sense data present

[Douglas Gilbert <dougg@torque.net>]

James Bottomley wrote:
> On Thu, 2004-08-26 at 12:59, Alan Stern wrote:
> 
>>No problems have come up in actual use.  I wrote the patch in response to 
>>the message below, from Douglas Gilbert (this was part of an interchange 
>>commenting on some proposed additions to the 
>>Documentation/scsi/scsi_mid_low_api.txt document -- see the section 
>>about Autosense).  Was he incorrect?
> 
> 
> I suspect that's because you've never seen any of the new types in
> practice.
> 
> 0x70 is really the only sense type we process correctly: Fixed Format. 
> 0x72 is the newer Descriptor Format.  0x71 and 0x73 are the Fixed and
> Descriptor format deferred sense conditions.
> 
> We really only get deferred errors if the device has a cache that is set
> to writeback, so we just hope never to see them...
> 
> I thought Doug had a proposal for unifying our view of Fixed vs
> Descriptor sense formats?

James,
Yes. I'll present it as a patch shortly.

With respect to deferred errors, we should not just ignore
them. At the very least they should be logged.

Doug Gilbert