Re: [PATCH] sg.c to set direction more reliably (was Re: [PATCH] fusion update to current APIs)

[Douglas Gilbert <dougg@torque.net>]

Jeremy Higdon wrote:
> On Thu, Aug 26, 2004 at 06:12:53PM -0700, Jeremy Higdon wrote:
> 
>>On Thu, Aug 26, 2004 at 06:44:40PM +1000, Douglas Gilbert wrote:
>>
>>>Jeremy,
>>>Perhaps the first argument of printk() could be prefixed with
>>>KERN_WARNING to make it a bit more syslog friendly.
>>>Otherwise ok.
>>>
>>>Doug Gilbert
>>
>>You're right.  It's fixed in this patch.
>>James, if you're satisfied, please apply.
> 
> 
> This is one of those days when I seem to be working against myself.
> It turns out that our RAID vendor modified their agent to trim
> the "reply_len" field for write commands, but did not trim the
> "count" field for read commands.  So in this case, sg actually
> guesses correctly when it needs to, and the app works.  Only with
> this patch, /var/log/messages gets filled with this new error
> message.
> 
> Doug, what do you think is the right thing to do?

Jeremy,
You could use a (block scope) static and only print out
the warning the first time it is detected.

Doug Gilbert