public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian King <brking@us.ibm.com>
To: Jeremy Higdon <jeremy@sgi.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: Control Mode page (0xA) QERR bit setting
Date: Tue, 31 Aug 2004 08:55:18 -0500	[thread overview]
Message-ID: <41348346.9030901@us.ibm.com> (raw)
In-Reply-To: <20040831024520.GA2118@sgi.com>

The ipr driver actually depends on QERR=1 and adapter firmware to do the 
right thing. TCQing doesn't get setup by the ipr driver until userspace 
enables it, and the userspace tool to enable it takes care of setting up 
QERR=1 before enabling it. When I get a check condition I send down a 
cancel all requests to the device, which is similar to an abort task 
set. The end result is that all commands that were silently aborted get 
returned to me with aborted status. Meanwhile, the device is in a state 
where it will always return a "not ready - synchronization required" 
response (pseudo ACA state), which I translate to DID_IMM_RETRY. I do 
the request sense and then clear this sync required state on the next 
command issued.

-Brian

Jeremy Higdon wrote:
> It looks as though the midlayer assumes that QERR is 0.  Is that correct?
> 
> If QERR is 0, then a check condition for one command will not affect other
> commands, whereas if QERR is 1, then when one command gets a check condition,
> all others for that ITL are silently aborted.
> 
> Since I wasn't able to find any code (other than in the ipr driver) that
> completed all outstanding commands to a Lun when a check condition is
> received, I figure that we depend on QERR=0.
> 
> thanks
> 
> jeremy
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center


      parent reply	other threads:[~2004-08-31 13:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-31  2:45 Control Mode page (0xA) QERR bit setting Jeremy Higdon
2004-08-31  3:33 ` James Bottomley
2004-08-31  4:48   ` Jeremy Higdon
2004-08-31 13:55 ` Brian King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41348346.9030901@us.ibm.com \
    --to=brking@us.ibm.com \
    --cc=jeremy@sgi.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox