dougg wrote: > The following scenario has been brought to my attention. > > While handling a error (e.g. a timeout) the > scsi_send_eh_cmnd() function issues a (stalled) queued command. > Now that command hits a repeatable failure (e.g. MEDIUM ERROR). > > In this scaenario it would seem that the "goto retry" forms > an infinite loop re-issuing that command on the same (broken) > block. > > Comments? No comments, so how about this patch. When the eh retries are exhausted the code drops through to FAILED state. If a command in foreground (i.e. not sent by the eh handler) exceeds it retries then SUCCESS is returned?? Doug Gilbert