From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Subject: Re: [linux-iscsi-devel] Re: [PATCH RFC] replace ioctl for sysfs take 2 Date: Mon, 06 Sep 2004 11:15:00 -0700 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <413CA924.8030904@cs.wisc.edu> References: <413557CB.8010008@cs.wisc.edu> <20040901162042.GC26753@null.msp.redhat.com> <20040906143251.GB21646@lst.de> <20040906163336.GE642@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from sabe.cs.wisc.edu ([128.105.6.20]:21394 "EHLO sabe.cs.wisc.edu") by vger.kernel.org with ESMTP id S268435AbUIFSPX (ORCPT ); Mon, 6 Sep 2004 14:15:23 -0400 In-Reply-To: <20040906163336.GE642@parcelfarce.linux.theplanet.co.uk> List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox Cc: Christoph Hellwig , iscsi -devel , David Wysochanski , "Surekha.PC" , linux-scsi@vger.kernel.org Matthew Wilcox wrote: > On Mon, Sep 06, 2004 at 04:32:51PM +0200, Christoph Hellwig wrote: > >>On Wed, Sep 01, 2004 at 11:20:42AM -0500, AJ Lewis wrote: >> >>>Do we want all these attributes in the scsi_host class, or should we put them >>>in the iscsi devices directory? So in /sys/bus/iscsi-sfnet/devices/iscsi1 - > > > Woah, woah, woah. What's this "iscsi-sfnet" directory in sysfs? That's > just wrong. It is only a pseudo bus for the driver from Christoph's suggestion, that's just to make probing and removing of the driver's devices easier (it looks like a normal scsi driver now). No way is that crap going into the kernel. We have to have > *one* iscsi infrastructure, not a dozen. > Don't worry, there is no way we are going to put transport, scsi or anything like that there. This driver will use the scsi-ml infrastucture for sysfs and this includes using the transport classes. I think this comment from AJ, was just in error when he was unaware of scsi-ml's transport classes.