Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3

[Mark Lord <lkml@rtr.ca>]

(Christoph Hellwig wrote:
 >
>  - the !dev case in qs_scsi_queuecomman can't happen

Are you sure?
I have seen it occur immediately after hot-removal
of a drive.  There have been other structural changes
since then, so perhaps it is no longer possible,
but I'd rather have the test there than have the
kernel ooops again.  If you feel strongly about it,
then away it goes.

>  - never mess with eh_timeout from inside a driver

Give us an interface for it, please.
In the meanwhile, gone!

>  - please don't implemente the HDIO_ ioctls, Jeff said this can
>    be done via SG_IO

SG_IO is incompatible with current user-mode toolsets.
Once that interface becomes more mature, and the distributions
gradually get updated with newer versions of the tools,
then the HDIO_ stuff can go (as per the comments in the source).
For now, it is essential for hdparm and smartmontools, among others.

Alternatively, as Jeff has suggested, we may be able to implement
a generic HDIO_ mechanism in libata that re-issues the commands
through SG_IO (perhaps that is what you meant).  Is that there now?

>  - if ->info return a static string you can just store it into ->name

So just nuke the _info() proc, and use .name = QS_DESC ?
Okay, done.

>  - please use the kernel/kthread.c interface for your kernel thread

Good -- I hadn't noticed that new interface before.

It's quite hard to find all of this stuff first time through,
as there are practically no existing drivers that don't have
many of the same comments applicable to them.

Perhaps this will be one of the first/few drivers
to become totally compliant with the latest kernel APIs.

Cheers
--
Mark Lord
(hdparm keeper & the original "Linux IDE Guy")