From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3 Date: Wed, 13 Oct 2004 18:16:49 -0400 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <416DA951.2090104@rtr.ca> References: <4161A06D.8010601@rtr.ca> <4165B233.9080405@rtr.ca> <416D8A4E.5030106@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from cpu1185.adsl.bellglobal.com ([207.236.110.166]:29893 "EHLO mail.rtr.ca") by vger.kernel.org with ESMTP id S269883AbUJMWSj (ORCPT ); Wed, 13 Oct 2004 18:18:39 -0400 In-Reply-To: <416D8A4E.5030106@pobox.com> List-Id: linux-scsi@vger.kernel.org To: Jeff Garzik Cc: Mark Lord , Linux Kernel , linux-scsi@vger.kernel.org >> >> Right now that's not as easy as it could be, due to the specialized >> libata struct parameters required, but I think it could be harmonized. > > >I recall this but don't see it in my inbox anymore... did I adequately respond? Well, that makes two of us that have lost the original. :) No response from you yet, and I don't want to waste the effort on patches if they'll be rejected outright, thus the initial query: The change would be as follows: Export ata_scsi_simulate(), and replace the first two parameters (struct ata_port, struct ata_device) with a pointer to the 512-byte drive IDENTIFY response data. That way, ata_scsi_simulate() becomes usable from drivers (like qstor) that are not libata based. The identify data parameter would, of course, also be propogated down into all of the associated helper functions that get invoked by ata_scsi_simulate() and pals. At present, this will work, since those routines are only interested in the identify data today, but I don't know about any future plans there might be for it all. Of course, even to use this, QStor will still have to create fake identify blocks for each RAID device.. Cheers -- Mark Lord (hdparm keeper & the original "Linux IDE Guy")