SCSI breaks 'make allyesconfig'

SCSI breaks 'make allyesconfig'

[Jeff Garzik]

Latest -bk:

[jgarzik@pretzel linux-2.6]$ make
   CHK     include/linux/version.h
make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
   CHK     include/linux/compile.h
   CHK     usr/initramfs_list
   LD      drivers/scsi/built-in.o
drivers/scsi/osst.o(.bss+0x0): In function `exit_osst':
drivers/scsi/osst.c:195: multiple definition of `ST_partstat'
drivers/scsi/st.o(.bss+0x0):drivers/scsi/st.c:244: first defined here
make[2]: *** [drivers/scsi/built-in.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

Re: SCSI breaks 'make allyesconfig'

[Jeff Garzik]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Jeff Garzik wrote:
> [jgarzik@pretzel linux-2.6]$ make
>   CHK     include/linux/version.h
> make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
>   CHK     include/linux/compile.h
>   CHK     usr/initramfs_list
>   LD      drivers/scsi/built-in.o
> drivers/scsi/osst.o(.bss+0x0): In function `exit_osst':
> drivers/scsi/osst.c:195: multiple definition of `ST_partstat'
> drivers/scsi/st.o(.bss+0x0):drivers/scsi/st.c:244: first defined here
> make[2]: *** [drivers/scsi/built-in.o] Error 1
> make[1]: *** [drivers/scsi] Error 2
> make: *** [drivers] Error 2


  ...and the attached patch fixes it.  'ST_partstat' is defined in 
drivers/scsi/st.h, but never used.

	Jeff



[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 326 bytes --]

===== drivers/scsi/st.h 1.20 vs edited =====
--- 1.20/drivers/scsi/st.h	2004-10-25 14:32:30 -04:00
+++ edited/drivers/scsi/st.h	2004-11-17 08:36:22 -05:00
@@ -67,7 +67,7 @@
 	u32 last_block_visited;
 	int drv_block;		/* The block where the drive head is */
 	int drv_file;
-} ST_partstat;
+};
 
 #define ST_NBR_PARTITIONS 4
 

Re: SCSI breaks 'make allyesconfig'

[James Bottomley]

On Wed, 2004-11-17 at 08:05, Jeff Garzik wrote:
> > drivers/scsi/osst.o(.bss+0x0): In function `exit_osst':
> > drivers/scsi/osst.c:195: multiple definition of `ST_partstat'
> > drivers/scsi/st.o(.bss+0x0):drivers/scsi/st.c:244: first defined here
> > make[2]: *** [drivers/scsi/built-in.o] Error 1
> > make[1]: *** [drivers/scsi] Error 2
> > make: *** [drivers] Error 2
> 
> 
>   ...and the attached patch fixes it.  'ST_partstat' is defined in 
> drivers/scsi/st.h, but never used.

Yes, this was reported and fixed yesterday.  The fix is already in the
SCSI BK repo:

http://linux-scsi.bkbits.net:8080/scsi-rc-fixes-2.6/cset@419a6d19FQrj1AswswaWWZLXreWppw

James

Re: SCSI breaks 'make allyesconfig'

[Matthew Wilcox]

On Wed, Nov 17, 2004 at 08:30:58AM -0500, Jeff Garzik wrote:
> drivers/scsi/osst.o(.bss+0x0): In function `exit_osst':
> drivers/scsi/osst.c:195: multiple definition of `ST_partstat'
> drivers/scsi/st.o(.bss+0x0):drivers/scsi/st.c:244: first defined here

Reported yesterday, and the patch was sent to linux-scsi.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain