Re: drivers/block/scsi_ioctl problem

[Brian King <brking@us.ibm.com>]

Jens Axboe wrote:
> On Tue, Dec 14 2004, Brian King wrote:
> 
>>Can someone explain to me the need for this bit of code in 
>>drivers/block/scsi_ioctl.c:
>>
>>if (!(type & CMD_WARNED)) {
>>	cmd_type[cmd[0]] = CMD_WARNED;
>>	printk(KERN_WARNING "scsi: unknown opcode 0x%02x\n", cmd[0]);
>>}
>>
>>I'm trying to convert an application to use SG_IO to /dev/sd* devices 
>>rather than using /dev/sg* devices and this is one problem I have been 
>>running into. Any time I issue a vendor specific scsi opcode I end up 
>>getting one of these error logs. Is there a good reason this error log 
>>is needed?
> 
> 
> It was added to be able to find out which opcode was rejected and thus
> caused an application malfunction. It dumps the specific opcode only
> once, is that such a huge problem?

Ok. I didn't realize that it was only dumped once. That's not as bad. I 
guess it might be better if it were only dumped if the op actually failed.


-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center