From: Douglas Gilbert <dougg@torque.net>
To: Andi Kleen <ak@muc.de>
Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Add compat_ioctl to SG
Date: Tue, 18 Jan 2005 21:35:53 +1000 [thread overview]
Message-ID: <41ECF499.9040501@torque.net> (raw)
In-Reply-To: <20050118110743.GD43344@muc.de>
Andi Kleen wrote:
<snip>
> @@ -1343,6 +1366,9 @@
> .write = sg_write,
> .poll = sg_poll,
> .ioctl = sg_ioctl,
> +#ifdef CONFIG_COMPAT
> + .ioctl = sg_compat_ioctl,
> +#endif
Andi,
Two initializations of ".ioctl" looks wrongs.
Comparing with the patch to sd should that be:
+ .compat_ioctl = sg_compat_ioctl,
??
Doug Gilbert
next prev parent reply other threads:[~2005-01-18 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-18 11:07 [PATCH] Add compat_ioctl to SG Andi Kleen
2005-01-18 11:35 ` Douglas Gilbert [this message]
2005-01-18 11:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ECF499.9040501@torque.net \
--to=dougg@torque.net \
--cc=James.Bottomley@SteelEye.com \
--cc=ak@muc.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox