* scsi_device::single_lun name change
@ 2005-02-16 0:57 Douglas Gilbert
2005-02-16 1:53 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: Douglas Gilbert @ 2005-02-16 0:57 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi
While looking at struct scsi_target in a recent lk 2.6
kernel I was confused by this sentence:
"scsi_target: representation of a scsi target, for now,
this is only used for single_lun devices." This is just above
the definition of the scsi_target structure in scsi_device.h
Elsewhere in that file scsi_device::single_lun is defined
with this comment:
"Indicates we should only allow I/O to one of the luns for
the device at a time."
That implies that the target must have multiple lus when
single_lun is set :-)
Is it too late to rename that field to something like:
serialize_lu_io or single_lu_io ?
Doug Gilbert
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: scsi_device::single_lun name change
2005-02-16 0:57 scsi_device::single_lun name change Douglas Gilbert
@ 2005-02-16 1:53 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2005-02-16 1:53 UTC (permalink / raw)
To: Douglas Gilbert; +Cc: SCSI Mailing List
On Wed, 2005-02-16 at 10:57 +1000, Douglas Gilbert wrote:
> "scsi_target: representation of a scsi target, for now,
> this is only used for single_lun devices." This is just above
> the definition of the scsi_target structure in scsi_device.h
Yes, I suppose that's historical junk now.
> Elsewhere in that file scsi_device::single_lun is defined
> with this comment:
> "Indicates we should only allow I/O to one of the luns for
> the device at a time."
> That implies that the target must have multiple lus when
> single_lun is set :-)
>
> Is it too late to rename that field to something like:
> serialize_lu_io or single_lu_io ?
Well, it corresponds to BLIST_SINGLELUN flag, so the naming scheme is
currently internally consistent.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-02-16 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-16 0:57 scsi_device::single_lun name change Douglas Gilbert
2005-02-16 1:53 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox