Re: [ANNOUNCE] Adaptec SAS/SATA device driver [03/27]

[Jeff Garzik <jgarzik@pobox.com>]

Luben Tuikov wrote:
> On 02/17/05 14:03, Jeff Garzik wrote:
> 
>> Luben,
>>
>> Your emails do not comply with the Linux kernel patch submission 
>> format.   Please read
>>     http://linux.yyz.us/patch-format.html
>>
>> Most critical is rule number #5 (signed-off-by line), but also 
>> important is rule number #1 (providing a useful subject line).
> 
> 
> Hi Jeff,
> 
> Thanks for you reply.  I'm well aware of the patch format.
> I wasn't sure about a different subject line since it it all part
> of a driver posting, "announce" rathern than "patch".

Yes, I understand that.

A key point is that it is impossible to differentiate your 27 patches, 
from looking at them in a email summary.  Putting a short summary of 
each patch in the email subject line greatly assists those reviewing 
your code.


> Yes, I forgot to add a signed off line.  Sorry, but then again
> I didn't write the code, just presenting it. (#5. Sign your work...)

"sign your work" is more of a legal sign-off than a notation of 
authorship.  In some cases, a company lawyer may be the person included 
in the signed-off-by line.

	Jeff