Re: [ANNOUNCE] Adaptec SAS/SATA device driver [0/27]

[Luben Tuikov <luben_tuikov@adaptec.com>]

On 02/17/05 15:57, James Bottomley wrote:
> Well, the initial reaction is yuk.
> 
> Just from a brief glance over the files, the code is full of obfuscation
> and unnecessary compatibility gunk which needs removing.
> 
> It's also full of the same queueing junk that I asked be taken out of
> the aic7xxx driver.

Thank you for all the comments guys!
 
> Then we get to the architectural stuff, which should really have been
> discussed before you wrote the driver, not after

Just for the record: I did *not* write this driver!  I was merely given
it to present it to the community.
 
> - We need a SAS and a PHY transport class.  Three of your files are to
> do domain discover and should actually be part of the SAS transport
> class.  In fact, it looks like a large amount of the code should be in
> the various transport classes.

I absolutely agree.
 
> - The SATA pieces should use libata instead of trying to reinvent what
> already exists.

I agree here as well.

Thanks for all the comments guys!
	Luben