* [ANNOUNCE] Adaptec SAS/SATA device driver [0/27]
@ 2005-02-17 17:34 Luben Tuikov
2005-02-17 19:38 ` Christoph Hellwig
2005-02-17 20:57 ` James Bottomley
0 siblings, 2 replies; 5+ messages in thread
From: Luben Tuikov @ 2005-02-17 17:34 UTC (permalink / raw)
To: SCSI Mailing List
Hi,
Adaptec would like to announce its SAS/SATA Linux device driver
for inclusion into the Linux kernel.
The driver supports Adaptec's AIC-94XX chip based, eight port SAS
and SATA 64-bit PCI-X, 133MHz ASIC controller.
The driver source is presented as a broken up BK patch over
the latest scsi-misc-2.6 kernel. The code is compatible
with both 2.4 and 2.6 kernels.
The authors of this code will be monitoring the mailing list
for your comments.
Thanks,
Luben
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2005/02/16 16:04:42-05:00 luben@luben.adaptec.com
# Adds support for Adaptec AIC-94XX chip based SAS/SATA controllers.
# This is a SCSI Low-Level Device Driver.
#
# drivers/scsi/adp94xx/readme.txt
# 2005/02/16 16:04:31-05:00 luben@luben.adaptec.com +289 -0
#
# drivers/scsi/adp94xx/readme.txt
# 2005/02/16 16:04:31-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/readme.txt
#
# drivers/scsi/adp94xx/adp94xx_seq.h
# 2005/02/16 16:04:30-05:00 luben@luben.adaptec.com +2840 -0
#
# drivers/scsi/adp94xx/adp94xx_seq.c
# 2005/02/16 16:04:30-05:00 luben@luben.adaptec.com +2845 -0
#
# drivers/scsi/adp94xx/adp94xx_seq.h
# 2005/02/16 16:04:30-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_seq.h
#
# drivers/scsi/adp94xx/adp94xx_seq.c
# 2005/02/16 16:04:30-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_seq.c
#
# drivers/scsi/adp94xx/adp94xx_sata.h
# 2005/02/16 16:04:29-05:00 luben@luben.adaptec.com +756 -0
#
# drivers/scsi/adp94xx/adp94xx_sata.c
# 2005/02/16 16:04:29-05:00 luben@luben.adaptec.com +3776 -0
#
# drivers/scsi/adp94xx/adp94xx_sata.h
# 2005/02/16 16:04:29-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_sata.h
#
# drivers/scsi/adp94xx/adp94xx_sata.c
# 2005/02/16 16:04:29-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_sata.c
#
# drivers/scsi/adp94xx/adp94xx_sas.h
# 2005/02/16 16:04:28-05:00 luben@luben.adaptec.com +1101 -0
#
# drivers/scsi/adp94xx/adp94xx_reg.h
# 2005/02/16 16:04:28-05:00 luben@luben.adaptec.com +2454 -0
#
# drivers/scsi/adp94xx/adp94xx_sas.h
# 2005/02/16 16:04:28-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_sas.h
#
# drivers/scsi/adp94xx/adp94xx_reg.h
# 2005/02/16 16:04:28-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_reg.h
#
# drivers/scsi/adp94xx/adp94xx_osm.h
# 2005/02/16 16:04:27-05:00 luben@luben.adaptec.com +1375 -0
#
# drivers/scsi/adp94xx/adp94xx_osm.h
# 2005/02/16 16:04:27-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_osm.h
#
# drivers/scsi/adp94xx/adp94xx_osm.c
# 2005/02/16 16:04:26-05:00 luben@luben.adaptec.com +5486 -0
#
# drivers/scsi/adp94xx/adp94xx_ioctl.h
# 2005/02/16 16:04:26-05:00 luben@luben.adaptec.com +277 -0
#
# drivers/scsi/adp94xx/adp94xx_osm.c
# 2005/02/16 16:04:26-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_osm.c
#
# drivers/scsi/adp94xx/adp94xx_ioctl.h
# 2005/02/16 16:04:26-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_ioctl.h
#
# drivers/scsi/adp94xx/adp94xx_ioctl.c
# 2005/02/16 16:04:25-05:00 luben@luben.adaptec.com +1041 -0
#
# drivers/scsi/adp94xx/adp94xx_inline.h
# 2005/02/16 16:04:25-05:00 luben@luben.adaptec.com +1075 -0
#
# drivers/scsi/adp94xx/adp94xx_ioctl.c
# 2005/02/16 16:04:25-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_ioctl.c
#
# drivers/scsi/adp94xx/adp94xx_inline.h
# 2005/02/16 16:04:25-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_inline.h
#
# drivers/scsi/adp94xx/adp94xx_hwi.h
# 2005/02/16 16:04:24-05:00 luben@luben.adaptec.com +1242 -0
#
# drivers/scsi/adp94xx/adp94xx_hwi.c
# 2005/02/16 16:04:24-05:00 luben@luben.adaptec.com +5675 -0
#
# drivers/scsi/adp94xx/adp94xx_hwi.h
# 2005/02/16 16:04:24-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_hwi.h
#
# drivers/scsi/adp94xx/adp94xx_hwi.c
# 2005/02/16 16:04:24-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_hwi.c
#
# drivers/scsi/adp94xx/adp94xx_discover.h
# 2005/02/16 16:04:23-05:00 luben@luben.adaptec.com +1252 -0
#
# drivers/scsi/adp94xx/adp94xx_discover.h
# 2005/02/16 16:04:23-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_discover.h
#
# drivers/scsi/adp94xx/adp94xx_discover.c
# 2005/02/16 16:04:22-05:00 luben@luben.adaptec.com +7418 -0
#
# drivers/scsi/adp94xx/Makefile
# 2005/02/16 16:04:22-05:00 luben@luben.adaptec.com +22 -0
#
# drivers/scsi/adp94xx/adp94xx_discover.c
# 2005/02/16 16:04:22-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/adp94xx_discover.c
#
# drivers/scsi/adp94xx/Makefile
# 2005/02/16 16:04:22-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/Makefile
#
# drivers/scsi/adp94xx/Kconfig
# 2005/02/16 16:04:21-05:00 luben@luben.adaptec.com +11 -0
#
# drivers/scsi/adp94xx/Kconfig
# 2005/02/16 16:04:21-05:00 luben@luben.adaptec.com +0 -0
# BitKeeper file /home/luben/projects/linux/2.6/scsi-misc-2.6/drivers/scsi/adp94xx/Kconfig
#
# drivers/scsi/Makefile
# 2005/02/16 16:04:21-05:00 luben@luben.adaptec.com +1 -0
# Add compilation directive for the Adaptec SAS/SATA driver.
#
# drivers/scsi/Kconfig
# 2005/02/16 16:04:21-05:00 luben@luben.adaptec.com +2 -0
# Add a configuration menu option of the Adaptec SAS/SATA driver.
#
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ANNOUNCE] Adaptec SAS/SATA device driver [0/27]
2005-02-17 17:34 [ANNOUNCE] Adaptec SAS/SATA device driver [0/27] Luben Tuikov
@ 2005-02-17 19:38 ` Christoph Hellwig
2005-02-17 20:57 ` James Bottomley
1 sibling, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2005-02-17 19:38 UTC (permalink / raw)
To: Luben Tuikov; +Cc: SCSI Mailing List
On Thu, Feb 17, 2005 at 12:34:41PM -0500, Luben Tuikov wrote:
> Hi,
>
> Adaptec would like to announce its SAS/SATA Linux device driver
> for inclusion into the Linux kernel.
>
> The driver supports Adaptec's AIC-94XX chip based, eight port SAS
> and SATA 64-bit PCI-X, 133MHz ASIC controller.
>
> The driver source is presented as a broken up BK patch over
> the latest scsi-misc-2.6 kernel. The code is compatible
> with both 2.4 and 2.6 kernels.
>
> The authors of this code will be monitoring the mailing list
> for your comments.
The driver is the same mess as aic7xxx and aic79xx and everything we
told you about it applies there aswell. Also as with the Fusion SAS
submission it won't go in until there's a SAS and phy transport class
to share common code between drivers.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ANNOUNCE] Adaptec SAS/SATA device driver [0/27]
2005-02-17 17:34 [ANNOUNCE] Adaptec SAS/SATA device driver [0/27] Luben Tuikov
2005-02-17 19:38 ` Christoph Hellwig
@ 2005-02-17 20:57 ` James Bottomley
2005-02-17 21:14 ` Luben Tuikov
1 sibling, 1 reply; 5+ messages in thread
From: James Bottomley @ 2005-02-17 20:57 UTC (permalink / raw)
To: Luben Tuikov; +Cc: SCSI Mailing List
On Thu, 2005-02-17 at 12:34 -0500, Luben Tuikov wrote:
> Adaptec would like to announce its SAS/SATA Linux device driver
> for inclusion into the Linux kernel.
Well, the initial reaction is yuk.
Just from a brief glance over the files, the code is full of obfuscation
and unnecessary compatibility gunk which needs removing.
It's also full of the same queueing junk that I asked be taken out of
the aic7xxx driver.
Then we get to the architectural stuff, which should really have been
discussed before you wrote the driver, not after
- We need a SAS and a PHY transport class. Three of your files are to
do domain discover and should actually be part of the SAS transport
class. In fact, it looks like a large amount of the code should be in
the various transport classes.
- The SATA pieces should use libata instead of trying to reinvent what
already exists.
James
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ANNOUNCE] Adaptec SAS/SATA device driver [0/27]
2005-02-17 20:57 ` James Bottomley
@ 2005-02-17 21:14 ` Luben Tuikov
2005-02-17 23:33 ` David Chaw
0 siblings, 1 reply; 5+ messages in thread
From: Luben Tuikov @ 2005-02-17 21:14 UTC (permalink / raw)
To: James Bottomley; +Cc: SCSI Mailing List
On 02/17/05 15:57, James Bottomley wrote:
> Well, the initial reaction is yuk.
>
> Just from a brief glance over the files, the code is full of obfuscation
> and unnecessary compatibility gunk which needs removing.
>
> It's also full of the same queueing junk that I asked be taken out of
> the aic7xxx driver.
Thank you for all the comments guys!
> Then we get to the architectural stuff, which should really have been
> discussed before you wrote the driver, not after
Just for the record: I did *not* write this driver! I was merely given
it to present it to the community.
> - We need a SAS and a PHY transport class. Three of your files are to
> do domain discover and should actually be part of the SAS transport
> class. In fact, it looks like a large amount of the code should be in
> the various transport classes.
I absolutely agree.
> - The SATA pieces should use libata instead of trying to reinvent what
> already exists.
I agree here as well.
Thanks for all the comments guys!
Luben
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ANNOUNCE] Adaptec SAS/SATA device driver [0/27]
2005-02-17 21:14 ` Luben Tuikov
@ 2005-02-17 23:33 ` David Chaw
0 siblings, 0 replies; 5+ messages in thread
From: David Chaw @ 2005-02-17 23:33 UTC (permalink / raw)
To: James Bottomley, SCSI Mailing List; +Cc: Luben Tuikov
Hi all,
Thanks for the all responses for this driver.
I really appreciate the comments / suggestions.
We definetely looking to making changes in the next few weeks.
Thanks again,
david
On Thu, 17 Feb 2005 16:14:36 -0500, Luben Tuikov
<luben_tuikov@adaptec.com> wrote:
> On 02/17/05 15:57, James Bottomley wrote:
> > Well, the initial reaction is yuk.
> >
> > Just from a brief glance over the files, the code is full of obfuscation
> > and unnecessary compatibility gunk which needs removing.
> >
> > It's also full of the same queueing junk that I asked be taken out of
> > the aic7xxx driver.
>
> Thank you for all the comments guys!
>
> > Then we get to the architectural stuff, which should really have been
> > discussed before you wrote the driver, not after
>
> Just for the record: I did *not* write this driver! I was merely given
> it to present it to the community.
>
> > - We need a SAS and a PHY transport class. Three of your files are to
> > do domain discover and should actually be part of the SAS transport
> > class. In fact, it looks like a large amount of the code should be in
> > the various transport classes.
>
> I absolutely agree.
>
> > - The SATA pieces should use libata instead of trying to reinvent what
> > already exists.
>
> I agree here as well.
>
> Thanks for all the comments guys!
> Luben
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-02-17 23:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-17 17:34 [ANNOUNCE] Adaptec SAS/SATA device driver [0/27] Luben Tuikov
2005-02-17 19:38 ` Christoph Hellwig
2005-02-17 20:57 ` James Bottomley
2005-02-17 21:14 ` Luben Tuikov
2005-02-17 23:33 ` David Chaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox