Re: [PATCH] 2.6 aacraid: endian cleanup

["Randy.Dunlap" <rddunlap@osdl.org>]

Mark Haverkamp wrote:
> On Mon, 2005-03-28 at 22:59 +0100, Christoph Hellwig wrote:
> 
>>On Mon, Mar 21, 2005 at 10:41:23AM -0800, Mark Haverkamp wrote:
>>
>>>A patch from Adaptec with byte order changes:
>>> - drop byte swapping on all 0's and all 1's content
>>> - fix up missing swapping directives
>>> - ensure swapping on 16 bit values does not use 32 bit swap
>>> - reconcile the readl/writel auto-swapping in only most of the
>>>configurations.
>>
>>that last bit is bogus.  readl/writel are defined to swap bytes on
>>big endian systems.  Whatever broken Mvista/Windriver or whatever port
>>doesn't do that should be fixed.
>>
>>Also please remove unrelated changes like the new cardtypes from the patch,
>>follow normal kernel codingstyle (e.g. ||, && at the end of the line) and
>>switch to __le* types for harware structures and make sure it's passing
>>sparse -Wbitwise.
> 
> 
> Sorry if this is a dumb question, but I haven't used sparse before.  If
> I do a make C=1, will that run sparse with the appropriate options?

sparse doesn't do bitwise by default, so you need to do

make C=1 CHECK="sparse -Wbitwise" drivers/scsi/filename.o  (e.g.)

-- 
~Randy