public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dougg@torque.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Frederic TEMPORELLI <frederic.temporelli@bull.net>,
	linux-scsi@vger.kernel.org
Subject: Re: proc_name in sysfs
Date: Fri, 08 Apr 2005 18:03:16 +1000	[thread overview]
Message-ID: <42563AC4.4050605@torque.net> (raw)
In-Reply-To: <20050408064645.GA4860@infradead.org>

Christoph Hellwig wrote:
> On Wed, Apr 06, 2005 at 01:40:04PM +0200, Frederic TEMPORELLI wrote:
> 
>>Hello,
>>
>>
>>We are using HBAs modules names from "proc_name" interface in sysfs:
>>/sys/class/scsi_host/hostX/proc_name.
>>
>>But with new Emulex drivers (8.0.21 and +), proc_name is reporting <NULL> 
>>(previous drivers were reporting "lpfc").
>>=> In the driver code, .proc_name field from scsi_host_template structure 
>>is no more initialized.
>>James Smart told us that the "removal" of .proc_name field (not really 
>>removed, but no more initialized) was part of the /proc interfaces removal 
>>(suggested by scsi-linux feedback).
>>
>>So:
>>1/ now, what is the aim of proc_name interface (reporting "<NULL>") in 
>>sysfs ?
>>2/ now, how can we get the adapter module name from sysfs ?
>>
>>=> I'm just thinking that .proc_name field has to be kept initialized 
>>and/or something has to be changed to replace the confusing "proc" prefix.
> 
> 
> The real problem is that someone decided to export the proc_name in sysfs.
> It's supposed to be only procfs-specific but someone violated that rule.

Forget the "proc_" part. It is effectively the lld_name.

Allowing the LLD to name itself to the scsi subsystem
makes sense, especially when the LLD is made up of several
kernel modules. See my previous example comparing the
output of lsscsi -H and scan_host.sh .

> Not sure how to proceed forward with this.

Doug Gilbert


  reply	other threads:[~2005-04-08  8:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-06 11:40 proc_name in sysfs Frederic TEMPORELLI
2005-04-06 18:36 ` Patrick Mansfield
2005-04-07  1:06   ` Douglas Gilbert
2005-04-07  6:35     ` Frederic TEMPORELLI
2005-04-07  8:17       ` Douglas Gilbert
2005-04-08  0:02       ` Patrick Mansfield
2005-04-08  7:37         ` Frederic TEMPORELLI
2005-04-08  0:00     ` Patrick Mansfield
2005-04-08  6:46 ` Christoph Hellwig
2005-04-08  8:03   ` Douglas Gilbert [this message]
2005-04-11 11:52     ` Christoph Hellwig
2005-04-11 14:19       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42563AC4.4050605@torque.net \
    --to=dougg@torque.net \
    --cc=frederic.temporelli@bull.net \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox