From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Subject: Re: scsi_transport_iscsi.c + transport_container_unregister() oops Date: Wed, 27 Apr 2005 12:03:54 -0700 Message-ID: <426FE21A.2010804@us.ibm.com> References: <1114626881.20844.15.camel@haakon> <426FDEE5.40408@us.ibm.com> <1114627774.20844.20.camel@haakon> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from e33.co.us.ibm.com ([32.97.110.131]:987 "EHLO e33.co.us.ibm.com") by vger.kernel.org with ESMTP id S261962AbVD0TEF (ORCPT ); Wed, 27 Apr 2005 15:04:05 -0400 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j3RJ434I613344 for ; Wed, 27 Apr 2005 15:04:03 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j3RJ43tY356368 for ; Wed, 27 Apr 2005 13:04:03 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j3RJ43fq018684 for ; Wed, 27 Apr 2005 13:04:03 -0600 In-Reply-To: <1114627774.20844.20.camel@haakon> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Nicholas A. Bellinger" Cc: linux-scsi , James Bottomley Nicholas A. Bellinger wrote: > On Wed, 2005-04-27 at 11:50 -0700, Mike Christie wrote: > >>Nicholas A. Bellinger wrote: >> >>>While adding support for the iSCSI Transport class >>>(scsi_transport_iscsi.c) to the iscsi-initiator-core stack, I ran into a >>>problem with iscsi_release_transport() and >>>transport_container_unregister(). >>> >>>When iscsi_register_transport() and iscsi_release_transport() are called >>>WITHOUT calling scsi_add_host() and scsi_remove_host() there are no >>>problems. >>> >>>When iscsi_register_transport() and iscsi_release_transport() are called >>>WITH calling scsi_add_host() and scsi_remove_host() the following OOPs >>>appears in attribute_container_unregister during the list_empty() loop. >>> >>>I also noticed that that transport_container_[register,unregister]() >>>calls in iscsi_[register,release]_transport() where added around >>>2.6.12-rc1, but are not included in the scsi_transport_iscsi.c within >>>the 4.0.1.11. >> >>The scsi_transport_iscsi.c in 4.0.1.11 is old. That version of the driver >>was for before James's transport container code so you cannot use the >>scsi_transport_iscsi.c in there with the current driver model transport >>code. >> >>Also you do not need to worry about sfnet compatibilty. If your changes >>are good/merged we will adapt to them. So do not worry about breaking >>us in the mean time. >> > > > Just to double check as I have not had a chance to test this myself, > does iscsi_release_transport() work correctly once a scsi host has been > registered with sfnet and 2.6.12-rc3's scsi_transport_iscsi.c? > Yes. Just double checked. > I am trying to make sure it is not something obvious I am missing on my > side. > > Thanks, >