Re: [PATCH] libata: device suspend/resume

Benjamin Herrenschmidt
2005-05-27T02:02:26Z

On Wed, 2005-05-25 at 11:29 +0200, Jens Axboe wrote:
> On Tue, May 24 2005, Jeff Garzik wrote:
> > Jens Axboe wrote:
> > >I agree, it's a cleaner approach, with the rq being a container for
> > >generel messages as well not just SCSI commands. The one missing piece
> > >for that was the rq->end_io() callback so everything doesn't have to go
> > >down sync, but that is in now as well.
> > >
> > >I'll try and cook something up.
> >
> > Very cool ;)
>
> This is the base for it. It splits request->flags into two variables:
>
> - cmd_type. this is not a bitmask, but a value indicating what type of
> request this is.
>
> - cmd_flags. various command modified flags.

I like it too. It's a long overdue cleanup :)

Another thing is we should/could probably move some of the other fields
in the struct request into a union of structs. Some of them are never
present simultaneously ...

Ben.