From: Jeff Garzik <jgarzik@pobox.com>
To: brking@us.ibm.com
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@steeleye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Re: sleeping in scsi EH
Date: Fri, 27 May 2005 12:54:44 -0400 [thread overview]
Message-ID: <429750D4.2060502@pobox.com> (raw)
In-Reply-To: <42972A72.8060600@us.ibm.com>
Brian King wrote:
> Jeff Garzik wrote:
>
>>Christoph Hellwig wrote:
>>
>>
>>>On Fri, May 27, 2005 at 04:37:29AM -0400, Jeff Garzik wrote:
>>>
>>>
>>>
>>>>Christoph Hellwig wrote:
>>>>
>>>>
>>>>
>>>>>You can sleep in them. You must however release the host lock and enable
>>>>>irqs first and reverse that before returning. The error handlers don't
>>>>>need the host lock, but we're stuck with the unfortunate calling convention
>>>>>for now.
>>>>
>>>>Why are we stuck with this calling convention, when everyone who cares
>>>>circumvents it?
>>>
>>>
>>>Because no one found the time to do a full transition yet. If you want to
>>>update all scsi drivers feel free. One patch per method please.
>>
>>
>
> Jeff,
>
> Please add the following patch to your eh_abort locking patch for the ipr driver.
> It fixes a race condition your patch would introduce. Thanks.
Which race is introduced? The SCSI EH does a lot of synchronization for
you...
Jeff
next prev parent reply other threads:[~2005-05-27 16:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 2:26 sleeping in scsi EH Jeff Garzik
2005-05-27 7:09 ` Christoph Hellwig
2005-05-27 8:37 ` Jeff Garzik
2005-05-27 8:42 ` Christoph Hellwig
2005-05-27 10:45 ` [PATCH] " Jeff Garzik
2005-05-27 10:52 ` Christoph Hellwig
2005-05-27 17:53 ` Jeff Garzik
2005-05-27 14:10 ` Brian King
2005-05-27 14:17 ` Matthew Wilcox
2005-05-27 14:35 ` Brian King
2005-05-27 16:54 ` Jeff Garzik [this message]
2005-05-27 17:35 ` Brian King
2005-05-27 15:01 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429750D4.2060502@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@steeleye.com \
--cc=brking@us.ibm.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox