From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [RFT][PATCH] aic79xx: remove busyq Date: Mon, 30 May 2005 18:48:11 -0400 Message-ID: <429B982B.2030907@pobox.com> References: <20050529074620.GA26151@havoc.gtf.org> <1117488507l.7621l.0l@werewolf.able.es> <429B9311.9000608@pobox.com> <1117492926l.11695l.0l@werewolf.able.es> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.dvmed.net ([216.237.124.58]:30188 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S261806AbVE3WsQ (ORCPT ); Mon, 30 May 2005 18:48:16 -0400 In-Reply-To: <1117492926l.11695l.0l@werewolf.able.es> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "J.A. Magallon" Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org J.A. Magallon wrote: > On 05.31, Jeff Garzik wrote: > >>J.A. Magallon wrote: >> >>>On 05.29, Jeff Garzik wrote: >>> >>> >>>>Can anyone with aic79xx hardware give me a simple "it works" >>>>or "this breaks things" answer, for the patch below? >>>> >>>>This changes the aic79xx driver to use the standard Linux SCSI queueing >>>>code, rather than its own. After applying this patch, NO behavior >>>>changes should be seen. >>>> >>>>The patch is against 2.6.12-rc5, but probably applies OK to recent 2.6.x >>>>kernels. >>>> >>> >>> >>>Applied with even no offsets to -rc5-mm1. Booted and working fine: >> >>Thanks a bunch! >> > > > Ooops, I forgot... > > CC drivers/scsi/aic7xxx/aic7xxx_osm_pci.o > drivers/scsi/aic7xxx/aic7xxx_osm.c: In function 'ahc_linux_register_host': > drivers/scsi/aic7xxx/aic7xxx_osm.c:1205: warning: ignoring return value of > 'scsi_add_host', declared with attribute warn_unused_result Yeah, that was there prior to my patch. We'll get it fixed up eventually. Jeff