Re: [PATCH] use spi_transport_class for aic79xx

[Hannes Reinecke <hare@suse.de>]

Jeff Garzik wrote:
> Hannes Reinecke wrote:
>> Hi James,
>>
>> you asked for it :-)
>> This patch updates aic79xx to use the spi transport class.
>> Wasn't even too hard.
>> Patch is relative to 2.6.12-rc6 + scsi-misc fixes.
>>
>> Comments etc. welcome.
>> Otherwise please apply.
> 
> Very nice, you saved me some work.
> 
Thought so.

> And, did you test it?  :)
> 
Ach, you don't trust me?

Seriously, yes I did test it here (Adaptec ASC-29320 U320).
The usual error applies (crashes on rmmod when disk-devices are
attached, removing devices by hand and rmmod afterwards works, though),
but apart from it seems to work.
And if not I can always blame the transport layer for it :-).
Next step is to connect an U320 drive to check it works properly.

> I would like to merge this with my aic changes (ports of James B's
> aic7xxx work), which removes the busyq, and soon, the completeq.
> 
As it happens I've just merged you aic branch with my update, so watch
this space. Next step is to include James' latest changes to aic7xxx
into the aic79xx also.

And I _really_ like to see the common parts merged.
Both drivers share a lot of code.

> See the 'aic' branch of
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
> 
See above. And it only took me 4hrs to figure out the git stuff ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux AG				S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html