Re: [PATCH] - mptfusion - adding back the spin locks in eh handle rs

[Luben Tuikov <luben_tuikov@adaptec.com>]

On 06/23/05 16:12, Moore, Eric Dean wrote:
> Ok, explain that to me why having our driver hang is a good thing.
> The task managment requests to our firmware stack are done in interrupt
> mode,
> thus we have sleep and have interrupts enabled in the eh threads waiting on
> the commands to complete.
> Christoph H. requested this change about 6 months ago, asking that we remove
> our watchdog timers in the eh threads, in favor of this design.

Hi Eric,

It is up to the LLDD to know how to deliver a TMF to the device.
Whether this is done purely in process context (iSCSI) or
in mixed context is up to the LLDD.

Also, most often than not, you'd want to wait for the TMF to
return (iSCSI), to know its status (although you can assume it without fault).

Nevertheless, calling the eh routines in process context is the way
to go. (in order to allow for "sleeping", on delivery you can disable ints
as appropriate for the hw)

	Luben