From: Jeff Garzik <jgarzik@pobox.com>
To: "Moore, Eric Dean" <Eric.Moore@lsil.com>
Cc: Luben Tuikov <luben_tuikov@adaptec.com>,
linux scsi <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@SteelEye.com>
Subject: Re: [PATCH] - mptfusion - adding back the spin locks in eh handle rs
Date: Thu, 23 Jun 2005 19:18:26 -0400 [thread overview]
Message-ID: <42BB4342.5060704@pobox.com> (raw)
In-Reply-To: <91888D455306F94EBD4D168954A9457C02DD8E97@nacos172.co.lsil.com>
Moore, Eric Dean wrote:
> Luben
>
> Ok - So you agree that completing Task management request
> in the same context as the eh threads is the way to go, right?
>
> Because that is what this LLD is doing. Have you had
> a chance to look at our code?
>
> That previous patch submitted by Jeff(I guess) was removing code which
> enabled interrupts. My patch was restoring it back to previous
> working code which doesn't hang the driver.
What was broken?
MPT abort handler would release the spinlock at the beginning, and
reacquire it at the end, essentially reversing the spinlocks in the old
spinlocked EH code.
Jeff
next prev parent reply other threads:[~2005-06-23 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 22:06 [PATCH] - mptfusion - adding back the spin locks in eh handle rs Moore, Eric Dean
2005-06-23 23:18 ` Jeff Garzik [this message]
2005-06-23 23:47 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2005-06-24 17:24 Moore, Eric Dean
2005-06-23 20:12 Moore, Eric Dean
2005-06-23 20:37 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42BB4342.5060704@pobox.com \
--to=jgarzik@pobox.com \
--cc=Eric.Moore@lsil.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox