Re: sbp2: modprobe -r fails, module allegedly in use

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Ben Collins wrote:
[James Bottomley wrote]
>>I notice that you don't do a scsi_device_put() after
>>scsi_add_device().  I think this is probably the source of the
>>refcounting errors: scsi_add_device returns an sdev with the refcount
>>incremented by one, so you need to decrement the count after you've
>>finished with it (in your case, you do nothing with it, so just
>>decrement after you've checked it's not an error pointer).
> 
> Thanks. Stefan, can you test with that change? I've already put it in the
> repo.

That fixes it. The error handler commits suicide when he should, and the
sbp2 module can be unloaded.

Thanks James.
-- 
Stefan Richter
-=====-=-=-= -=== -=-=-
http://arcgraph.de/sr/