Re: changes to ieee1394/sbp2 outside of linux1394.org

James Bottomley
2005-07-09T16:35:05Z

On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote:
> THese changes break sbp2, and we'll need to revert them in the main stream
> kernel until the patch is tested and fixed in our tree.

They cannot be simply reverted. The API has changed from the EH
routines being called with the host lock held to being called lockless.
If you need the lock, you have to take it yourself, which is what the
changes do from my reading of the code.

What's the breakage?

James