Re: changes to ieee1394/sbp2 outside of linux1394.org

Ben Collins
2005-07-09T17:49:59Z

On Sat, Jul 09, 2005 at 11:35:01AM -0500, James Bottomley wrote:
> On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote:
> > THese changes break sbp2, and we'll need to revert them in the main stream
> > kernel until the patch is tested and fixed in our tree.
>
> They cannot be simply reverted. The API has changed from the EH
> routines being called with the host lock held to being called lockless.
> If you need the lock, you have to take it yourself, which is what the
> changes do from my reading of the code.

It's not the lock change that is breaking things, it's the RBC changes.
SBP2 simply doesn't work (incorrect information read from the driver,
which I assume is bad translation of the scsi commands caused by the
changes).

--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
SwissDisk - http://www.swissdisk.com/