linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukasz Kosewski <lkosewsk@nit.ca>
To: jgarzik@pobox.com, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] Add disk hotswap support to libata
Date: Thu, 21 Jul 2005 17:14:12 -0400	[thread overview]
Message-ID: <42E01024.9030600@nit.ca> (raw)

Hey all, introductory blurb here.

This sequence of patches will add a framework to libata to allow for 
hot-swapping disks in and out.

There are three patches:
01-promise_sataII150_support
02-libata_hotswap_infrastructure
03-promise_hotswap_support

The rationale for each will be described in following emails.

I encourage anyone with design ideas to come forward and contribute, and 
anyone who can see concurrency problems (I will describe what I see as 
issues along with the second patch) to suggest fixes.

Thus far, I've tested this HEAVILY with a 2.6.11.12 kernel + 
2.6.11-libata-dev1.patch.  I have found no issues outstanding on that 
kernel.  All testing was done with Promise SATA150 and SATAII150 Tx4/Tx2 
  Plus controllers and a huge variety of Western Digital and Seagate disks.

I have ported my patches to 2.6.13-rc3 and 2.6.13-rc3-mm1, and have 
tested on the latter as well; they work identically to the 2.6.11 tests 
except for a breakage in the SCSI layer [1].

The patches I will attach apply to the latter (2.6.13-rc3-mm1) tree, 
since I expect that by the time people start looking at them seriously, 
the existing libata patches in that tree will have become part of 
mainline.  If this is NOT the right thing to do, please tell me, and 
I'll submit patches for the requested kernel version.

Enjoy!

Luke Kosewski
Human Cannonball
Net Integration Technologies

[1]  The SCSI error on 2.6.13-rc3-mm1 that I found:
'echo "scsi add-single-device a b c d" > /proc/scsi/scsi'  //works, or 
no-op if the sd corresponding to that device is there already
'echo "scsi remove-single-device a b c d" > /proc/scsi/scsi'  //works
'echo "scsi add-single-device a b c d" > /proc/scsi/scsi'  //works
'echo "scsi remove-single-device a b c d" > /proc/scsi/scsi'  //FAILS

As such, since the same underlying functions are called by hotplugging, 
you will only be able to remove a disk from a device once before it 
fails, until this error is fixed.  I'll look into it as well.

             reply	other threads:[~2005-07-21 21:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-21 21:14 Lukasz Kosewski [this message]
2005-07-21 21:58 ` [PATCH 0/3] Add disk hotswap support to libata Michael Tokarev
2005-07-21 22:14   ` Lukasz Kosewski
2005-07-22  1:35 ` Jeff Garzik
2005-07-22 18:31   ` Lukasz Kosewski
2005-07-28 18:54   ` Doug Maxey
2005-07-28 19:05     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42E01024.9030600@nit.ca \
    --to=lkosewsk@nit.ca \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).