Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Jens Axboe <axboe@suse.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH RFC] allow bio code to unmap sg io requests and have blk_execute_rq_nowait bounce bios
Date: Sat, 06 Aug 2005 11:25:00 -0500	[thread overview]
Message-ID: <42F4E45C.90106@cs.wisc.edu> (raw)
In-Reply-To: <20050802084905.GC22569@suse.de>

Jens Axboe wrote:
> On Fri, Jul 29 2005, Mike Christie wrote:
> 
>>Hey Jens and James,
>>
>>The inlined patch moves the bounce buffer handling to blk_execute_rq_nowait
>>so the scsi, sg io and cdrom code does not have to handle it. To accomplish
>>this I moved the bio_uncopy_user to a bi_end_io function and bio_unmap_user
>>to a work struct that is schedule from a bi_end_io functions. Did you say
>>you disliked the idea of calling bio_unmap_user from a work struct - don't
>>remember and I lost my emails when I moved? :(
> 
> 
> It's probably alright, it cleans up the code a lot. It will cost some
> extra context switches, but I'm naively hoping that for busy io we will
> have good batching of the processing anyways.
> 

Doh! I ported sg.c and noticed I messed up. copy_to_user must be called
from user context so my patch does not work for that path.

      parent reply	other threads:[~2005-08-06 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-29  9:20 [PATCH RFC] allow bio code to unmap sg io requests and have blk_execute_rq_nowait bounce bios Mike Christie
2005-07-29  9:28 ` Mike Christie
     [not found] ` <20050802084905.GC22569@suse.de>
2005-08-06 16:25   ` Mike Christie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42F4E45C.90106@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=axboe@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox