Re: [RFC] libata new EH document

Luben Tuikov
2005-09-01T21:40:44Z

On 09/01/05 09:24, James Bottomley wrote:
> On Thu, 2005-09-01 at 01:54 -0400, Jeff Garzik wrote:
>
>>The long term direction for the SCSI core seems to be that of
>>requiring auto-sensing.
>
>
> No, I don't see the mid-layer error thread handling of this ever going
> away.
>
>>libata is simply being lazy: while the SCSI core continues to support
>>kicking the EH thread when sense is missing, it's preferred for libata
>>to reuse that infrastructure.
>
>
> That makes the most sense ;-)

For libata it doesn't really matter, since it is _ATA_.

> The current SCSI autosense in drivers doesn't require this because we
> reuse the existing command that got the contingent allegiance condition.

Care to elaborate what "contingent allegiance condition" is,
how SCSI Core got it, how SCSI Core is using it, and how SCSI Core set
it up with the LU?

> This is the piece I'd like to get rid of because the extra fields and
> extra setup to allow the command to be reused are a critical path hit.

If you _do_ get rid of the extra fields, then you _really_ need
LLDD/protocols to support autosense.

> If you look at any driver that does this (53c700.c for instance) you'll
> see that the command is turned around and resubmitted in the irq
> routine).

That's ok.

Luben