From: Mike Christie <michaelc@cs.wisc.edu>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
Alex Aizman <itn780@yahoo.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Andrew Vasquez <andrew.vasquez@qlogic.com>
Subject: Re: [PATCH] move iscsi to a better place in Kconfig
Date: Fri, 09 Sep 2005 12:33:18 -0500 [thread overview]
Message-ID: <4321C75E.8090204@cs.wisc.edu> (raw)
In-Reply-To: <4321C044.3020605@cs.wisc.edu>
Mike Christie wrote:
> James Bottomley wrote:
>
>> On Thu, 2005-09-08 at 14:23 -0500, Mike Christie wrote:
>>
>>> I think the reason it was a dependency was becuase the transport
>>> class manages does the lifetime management/refcounting for the
>>> initiators/iscsi_tcp.c session struct. scsi_transport_iscsi allocates
>>> the scsi_host, and the initiator/iscsi_tcp.c's session structure is
>>> allocated in that host_data.
>>
>>
>>
>> Yes, but Kconfig isn't about lifetimes or, in fact, much of the way the
>> code is constructed; it's about how the user selects particular
>> features.
>>
>> In the current setup, they have to know to say Y/M to the ISCSI
>> attribute question even to see the config option for the iscsi
>> initiator. This is a bit counter intuitive (and definitely isn't the
>> way any of the other drivers that depend on transport classes are
>> presented).
>>
>
> Yeah, sorry about that. With the userspace split and interpreting and
> implementing the review comments everything got a bit mixed up and we
> ended up the using the classes in a strange way. Should we resplit
> things up so that the host_alloc code is not part of the transport
> class? I think this will help the ql4xxx guys, Andrew have you started
> that?
And/or are there parts of the netlink interface you can use or will
everything be done your fw/nvram? For example can you put part of the
iSNS stuff in userspace then communicate through a modified iscsi
netlink interface or is it not worth it or possible?
prev parent reply other threads:[~2005-09-09 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 14:56 [PATCH] move iscsi to a better place in Kconfig James Bottomley
2005-09-08 19:23 ` Mike Christie
2005-09-09 15:01 ` James Bottomley
2005-09-09 17:03 ` Mike Christie
2005-09-09 17:33 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4321C75E.8090204@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@SteelEye.com \
--cc=andrew.vasquez@qlogic.com \
--cc=itn780@yahoo.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox