Re: [PATCH RFC/RFT 2/4] add scsi helpers

[Mike Christie <michaelc@cs.wisc.edu>]

Mike Christie wrote:
>>
>>
>>> +int scsi_execute_async_iov_req(struct scsi_device *sdev,
>>> +                   const unsigned char *cmd, int data_direction,
>>> +                   struct kvec *vec, int vec_count, int timeout,
>>> +                   int retries, void *privdata,
>>> +                   void (*done)(void *, char *, int, int))
>>
>>
>>
>> If you passed an request_queue_t instead of th scsi_device this function
>> would not have any knowledge about scsi internals and could be moved up
>> to the block layer.  not sure that's actually a good idea.
> 
> 
> Did you want to move scsi_execute too?
> 

Actually after talking with Jens, I think it is better to keep the 
function in scsi_lib and move my blk_rq_map_iov() function there. The 
problem is that sg and st have some special needs and as a result do 
some things like partial setup themselves. It looks like nobody wants 
the burdon of having these special case fucntions :) but since SCSI's 
ULDs are the only user and probably will be the only user does it make 
sense to keep them there?