From: Mike Christie <michaelc@cs.wisc.edu>
To: axboe@suse.de
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix retries and command completion when using REQ_BLOCK_PC
Date: Sun, 18 Sep 2005 14:58:43 -0500 [thread overview]
Message-ID: <432DC6F3.80801@cs.wisc.edu> (raw)
In-Reply-To: <1127063944.1421.16.camel@max>
Mike Christie wrote:
> Hi Jens and James,
>
> As you know a side effect of SCSI using REQ_BLOCK_PC is that commands
> that used to originate from SCSI do not obey the retries value, and we
> now add extra processing of failures in scsi_io_completion.
>
> The patch below adds a retry count on the request which is used like the
> timeout value. And it changes scsi_generic_done to always complete the
> entire command which emulates the old behavior we had with
> scsi_wait_req/scsi_do_req where scsi_io_completeion does not process the
> error and request additional retries.
>
Oh yeah this is also what sd does with REQ_BLOCK_PC commands and with my
other patch for st in this mail
http://marc.theaimsgroup.com/?l=linux-scsi&m=112708046601499&w=2 it is
what tape will do.
next prev parent reply other threads:[~2005-09-18 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 17:19 [PATCH] fix retries and command completion when using REQ_BLOCK_PC Mike Christie
2005-09-18 19:58 ` Mike Christie [this message]
2005-09-18 20:47 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432DC6F3.80801@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).