Re: [PATCH] 3ware: use scsi_scan_target()

[Jeff Garzik <jgarzik@pobox.com>]

Christoph Hellwig wrote:
> On Mon, Oct 03, 2005 at 08:57:46PM -0400, Jeff Garzik wrote:
> 
>>This change updates the 3ware raid drivers to use scsi_scan_target(), 
>>rather than scsi_scan_host().  This is especially nice for 3w-xxxx, 
>>which does not support LUNs.  The device scan is a bit quicker and more 
>>direct, even if it is a tiny bit more code in the driver.
> 
> 
> if it doesn't support luns scsi_add_device sounds like the better
> interface to use.

That applies to 3w-xxxx, certainly.

I don't see a strong argument for scsi_add_device() over 
scsi_scan_target(), though.  scsi_scan_target() directly supports the 
generic struct device/class_device stuff, and supports both wildcard LUN 
scans as well as no-LUN targets.  My vague preference would be to use 
scsi_scan_target() unless there is a strong reason not to...


> How does 3x-9xxx support luns?  From reading the
> code it doesn't seem to support passthru and faking up LUNs for logical
> volumes sounds odd.

[other emails appear to have addressed this]

	Jeff