Re: [PATCH 0/3] libata: scsi error handling, encore

[Luben Tuikov <luben_tuikov@adaptec.com>]

On 10/09/05 09:23, Jeff Garzik wrote:
> 4) I excised the following chunk from patch #2, before applying:
> 
> 
>>@@ -1572,7 +1628,7 @@
>> 		 * time).  We need to issue REQUEST SENSE some other
>> 		 * way, to avoid completing the command twice.
>> 		 */
>>-		cmd->result = SAM_STAT_CHECK_CONDITION;
>>+		cmd->result = (DRIVER_SENSE << 24) | SAM_STAT_CHECK_CONDITION;
>> 
>> 		qc->scsidone(cmd);
> 
> 
> We don't yet have sense at this point; the code above largely serves as 
> a trigger to a SCSI EH kthread, which will wake up and issue REQUEST 
> SENSE for us.  Its a bit of a weird setup, and I'm also working in this 
> area, so I simply removed the above quoted change from your patch, which 
> was applied otherwise unaltered.

If libata-scsi aspires to become SATL*, it needs to implement
autosense (which has been the norm since 2002 and everyone has
already forgotten this word, since it is the norm).

E.g. If you look at the SAS Code, you have more than enough
information to generate it (see sas_task.h::struct ata_task_resp).

	Luben
* libata-scsi would need a _lot_ of changes to become SATL.  Would
it be more efficient to start from a clean slate (drivers/scsi/satl/satl.c)
or change libata-scsi beyond recognition?  What is the political stance
on this?

-- 
http://linux.adaptec.com/sas/
Disclaimer: Opinions stated in this email are my own, not of my employer.
For inquiries write to: luben_tuikov@adaptec.com or ltuikov@yahoo.com.